Release v6.20.0

CHANGELOG.md

@@ -1,6 +1,21 @@
 Changelog
 =========
 
+## v6.20.0 (29 March 2021)
+
+### Enhancements
+
+* Classify `ActionDispatch::Http::MimeNegotiation::InvalidType` as info severity level
+  | [#654](https://github.com/bugsnag/bugsnag-ruby/pull/654)
+
+### Fixes
+
+* Include `connection_id` in ActiveRecord breadcrumb metadata on new versons of Rails
+  | [#655](https://github.com/bugsnag/bugsnag-ruby/pull/655)
+* Avoid crash when Mongo 1.12 or earlier is used
+  | [#652](https://github.com/bugsnag/bugsnag-ruby/pull/652)
+  | [isabanin](https://github.com/isabanin)
+
 ## 6.19.0 (6 January 2021)
 
 ### Enhancements

VERSION

@@ -1 +1 @@
-6.19.0
+6.20.0

features/fixtures/rails5/app/Gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
-gem 'rails', '~> 5.0.0'
+gem 'rails', '~> 5'
 # Use sqlite3 as the database for Active Record
 gem 'sqlite3', '< 1.4'
 # Use Puma as the app server

features/fixtures/rails5/app/config/initializers/new_framework_defaults.rb

@@ -17,8 +17,5 @@
 # Require `belongs_to` associations by default. Previous versions had false.
 Rails.application.config.active_record.belongs_to_required_by_default = true
 
-# Do not halt callback chains when a callback returns false. Previous versions had true.
-ActiveSupport.halt_callback_chains_on_return_false = false
-
 # Configure SSL options to enable HSTS with subdomains. Previous versions had false.
 Rails.application.config.ssl_options = { hsts: { subdomains: true } }

features/fixtures/rails6/app/Gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 # Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
-gem 'rails', '~> 6.0.0.beta3'
+gem 'rails', '~> 6'
 # Use sqlite3 as the database for Active Record
 gem 'sqlite3', '~> 1.3', '>= 1.3.6'
 # Use Puma as the app server
@@ -55,4 +55,4 @@ gem 'bugsnag', path: '/bugsnag'
 
 gem "mongoid"
 
-gem "clearance", "~> 1.16"
+gem "clearance", "~> 1.16"

lib/bugsnag/integrations/mongo.rb

@@ -127,6 +127,8 @@ def event_commands
   end
 end
 
-##
-# Add the subscriber to the global Mongo monitoring object
-Mongo::Monitoring::Global.subscribe(Mongo::Monitoring::COMMAND, Bugsnag::MongoBreadcrumbSubscriber.new)
+if defined?(Mongo::Monitoring)
+  ##
+  # Add the subscriber to the global Mongo monitoring object
+  Mongo::Monitoring::Global.subscribe(Mongo::Monitoring::COMMAND, Bugsnag::MongoBreadcrumbSubscriber.new)
+end

lib/bugsnag/integrations/rails/rails_breadcrumbs.rb

@@ -38,6 +38,8 @@ module Bugsnag::Rails
       :type => Bugsnag::Breadcrumbs::PROCESS_BREADCRUMB_TYPE,
       :allowed_data => [
         :name,
+        # :connection_id is no longer provided in Rails 6.1+ but we can get it
+        # from the :connection key of the event instead
         :connection_id,
         :cached
       ]

lib/bugsnag/integrations/railtie.rb

@@ -91,10 +91,21 @@ def event_subscription(event)
         filtered_data = data.slice(*event[:allowed_data])
         filtered_data[:event_name] = event[:id]
         filtered_data[:event_id] = event_id
-        if event[:id] == "sql.active_record" && data.key?(:binds)
-          binds = data[:binds].each_with_object({}) { |bind, output| output[bind.name] = '?' if defined?(bind.name) }
-          filtered_data[:binds] = JSON.dump(binds) unless binds.empty?
+
+        if event[:id] == "sql.active_record"
+          if data.key?(:binds)
+            binds = data[:binds].each_with_object({}) { |bind, output| output[bind.name] = '?' if defined?(bind.name) }
+            filtered_data[:binds] = JSON.dump(binds) unless binds.empty?
+          end
+
+          # Rails < 6.1 included connection_id in the event data, but now
+          # includes the connection object instead
+          if data.key?(:connection) && !data.key?(:connection_id)
+            # the connection ID is the object_id of the connection object
+            filtered_data[:connection_id] = data[:connection].object_id
+          end
         end
+
         Bugsnag.leave_breadcrumb(
           event[:message],
           filtered_data,

lib/bugsnag/middleware/classify_error.rb

@@ -9,6 +9,7 @@ class ClassifyError
         "ActionController::UnknownAction",
         "ActionController::UnknownFormat",
         "ActionController::UnknownHttpMethod",
+        "ActionDispatch::Http::MimeNegotiation::InvalidType",
         "ActiveRecord::RecordNotFound",
         "CGI::Session::CookieStore::TamperedWithCookie",
         "Mongoid::Errors::DocumentNotFound",