Include the connection ID in ActiveRecord breadcrumbs on new version of Rails #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
approved these changes
Mar 26, 2021
imjoehaines
force-pushed
the
include-connection-id-in-breadcrumbs
branch
from
70866ba
to
9266668
Compare
imjoehaines
force-pushed
the
include-connection-id-in-breadcrumbs
branch
from
9266668
to
c2eab54
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Rails replaced the connection ID with a connection object in ActiveRecord instrumentation. We will now get the ID from the connection object, as before
This is partly tested by existing tests and is tested against Rails 6.1 in #656