Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen restriction on Delayed Job version in MR tests #644

Merged
merged 1 commit into from
Dec 21, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions features/delayed_job.feature
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Scenario: An unhandled RuntimeError sends a report with arguments
And the event "metaData.job.payload.display_name" equals "TestModel.fail_with_args"
And the event "metaData.job.payload.method_name" equals "fail_with_args"
And the payload field "events.0.metaData.job.payload.args.0" equals "Test"
And the event "device.runtimeVersions.delayed_job" equals "4.1.8"
And the event "device.runtimeVersions.delayed_job" matches "\d+\.\d+\.\d+"

Scenario: A handled exception sends a report
Given I run the service "delayed_job" with the command "bundle exec rake delayed_job_tests:notify_with_args"
Expand All @@ -37,7 +37,7 @@ Scenario: A handled exception sends a report
And the event "metaData.job.payload.display_name" equals "TestModel.notify_with_args"
And the event "metaData.job.payload.method_name" equals "notify_with_args"
And the payload field "events.0.metaData.job.payload.args.0" equals "Test"
And the event "device.runtimeVersions.delayed_job" equals "4.1.8"
And the event "device.runtimeVersions.delayed_job" matches "\d+\.\d+\.\d+"

Scenario: The report context uses the class name if no display name is available
Given I run the service "delayed_job" with the command "bundle exec rake delayed_job_tests:report_context"
Expand All @@ -55,4 +55,4 @@ Scenario: The report context uses the class name if no display name is available
And the event "metaData.job.max_attempts" equals 1
And the event "metaData.job.payload.display_name" is null
And the event "metaData.job.payload.method_name" is null
And the event "device.runtimeVersions.delayed_job" equals "4.1.8"
And the event "device.runtimeVersions.delayed_job" matches "\d+\.\d+\.\d+"