Release v6.18.0 #641
Merged
Release v6.18.0 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We avoid reporting SystemExit exceptions as they aren't (usually) errors. However, Bundler's friendly errors will wrap an exception in a SystemExit — in this case we need to unwrap to the original exception
This proves that we don't unwrap exceptions too much when unwrapping Bundler's friendly errors. In this case, the backtrace will look something like this: 1. Bundler friendly errors 2. Our exit 3. The exception we raised We want to drop 1. because it may be hiding a real exception, however we don't want to drop 2. because it's a deliberate exit This test proves that we don't go too far and end up with an exception that we would notify about
Workaround Bundler's friendly errors swallowing error reports
Added a note that in order to run the specs, you may need to install the bundle with the `--with test` command line option in order to install the `test` group of gems, including `rake`. Otherwise you end up with an error like this: ```bash $ be rake spec bundler: failed to load command: rake (/Users/joshuapinter/.rbenv/versions/2.6.5/bin/rake) Gem::Exception: can't find executable rake for gem rake. rake is not currently included in the bundle, perhaps you meant to add it to your Gemfile? ``` Wasted 15 minutes figuring out what the issue was so this should help others contribute.
This step is necessary before running the test suite.
`rake` defaults to `rake spec` and in the `TESTING.md` file it just uses `rake`, so we should be consistent.
Add Note for installing test group gems.
This is temporary to get CI passing, not something we want to keep!
Pending future work to fix them
Fix CI issues
Breadcrumbs now have milliseconds included, which allows for the Bugsnag app to display the timestamps more accurately
Increase timestamp resolution to include milliseconds
Add timeout to all Buildkite steps
kattrali
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.18.0 (27 October 2020)
Enhancements
Bugsnag should now report uncaught exceptions inside Bundler's 'friendly errors'
| #634
Improve the display of breadrumbs in the Bugsnag app by including milliseconds in timestamps
| #639