[CI] Add tests for app_type in integrations #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jul 30, 2020
imjoehaines
force-pushed
the
app-type-tests
branch
2 times, most recently
from
96bfd22
to
fc742d8
Compare
These run the lowest Ruby version and highest Ruby version to avoid taking too much time
This still runs more builds at once than before because there are 4 concurrency groups which run 4 concurrent builds (12 total), whereas there was only 1 concurrency group which ran 8 builds I think this is OK because the integrations and unit tests run in ~1-2 minutes each, so the extra builds shouldn't be around for long The "plain" tests and Rails tests take the longest and are limited to the same concurrency as before so the impact of this change on other pipelines should be minor
With how slow the rails tests are these should run before those finish as they are in separate concurrency groups, which means the total build time won't increase
imjoehaines
force-pushed
the
app-type-tests
branch
from
fc742d8
to
f9d2716
Compare
Cawllec
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This is #532 brought up to date with the new Maze Runner tests added to Buildkite
There is still some future work to add missing integrations and in-Rails integrations:
I've changed up the concurrency in the Buildkite pipeline because so many new tests are added. There are now three concurrency groups:
The integrations and unit tests are limited to 4 concurrent builds, which doesn't take too long as they only take ~1-2 minutes each. The slow tests are limited to 8 concurrent builds, which was the limit before this PR
For about 10-15 minutes we can run up to 16 concurrent builds, which might be too many (?) but after that the integrations and unit tests finish, leaving only the 8 "slow" builds to finish. I think this is OK as we only block builds in other repos with the increased concurrency for 1-2 minutes at a time, but we can tweak it further if necessary (e.g. merging the integrations and unit tests would leave a maximum of 12 builds and might not prolong the total build time)