Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert frozen middleware error into a warning in the Rails integration #611

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Convert frozen middleware error into a warning in the Rails integration #611

merged 1 commit into from
Jul 27, 2020

Commits on Jul 27, 2020

  1. Supress frozen middleware errors in Railtie 

    This should never happen in normal operation, but is possible when
running RSpec tests

See thoughtbot/factory_bot_rails#303 (comment)
and #534

Essentially this happens:
1. RSpec boots Rails
2. Rails boot process errors
3. Rails freezes middleware
4. RSpec moves on to the next test file
5. Bugsnag tries to add middleware but fails because it's frozen
6. The stacktrace blames Bugsnag for this test failure
7. goto 4

Supressing this error doesn't solve the problem as it's likely another
frozen error will happen in some other library/component, but we want
to avoid people thinking this is caused by Bugsnag. The stacktrace
does point out the actual problem, but only in the very first error,
which can get buried under the frozen errors that happen for each
test file
    @imjoehaines
    imjoehaines committed Jul 27, 2020
    Configuration menu
    Copy the full SHA
    a530de7 View commit details
    Browse the repository at this point in the history