Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify redis gem version for Ruby 2.2 #546

Merged
merged 2 commits into from
Jun 11, 2019

Conversation

tobyhs
Copy link
Contributor

@tobyhs tobyhs commented Jun 11, 2019

Goal

Fix the Travis build for Ruby 2.2 and Sidekiq. I also started using Gem::Version as that seems to be more accurate, especially when version components are more than one digit.

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

Sidekiq depends on the redis gem, and redis 4.1.2 drops support for Ruby
2.2.
@tobyhs
Copy link
Contributor Author

tobyhs commented Jun 11, 2019

It looks like the branch build for this passed (after I retried many times). I'm now encountering the same rvm issues with the pull request build on the jruby-19mode job (where running rvm get stable tries to download https://github.com/rvm/rvm/archive/.tar.gz ; the branch/tag/version is missing) that doesn't appear to be related to this change (as the failure also comes up many times on a whitespace change).

@tobyhs tobyhs merged commit 2cd0138 into master Jun 11, 2019
@tobyhs tobyhs deleted the tobyhs/specify_redis_version_for_ruby_lt_2.3 branch June 11, 2019 21:22
@tobyhs tobyhs mentioned this pull request Jun 11, 2019
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants