Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update maze support #496

Merged
merged 8 commits into from
Nov 21, 2018
Merged

Update maze support #496

merged 8 commits into from
Nov 21, 2018

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 15, 2018

Goal

Updates maze tests to reflect changes recently made to Bugsnag-maze-runner.
Includes:

  • Removes unnecessary and conflicting steps
  • Ensure route tests reflect fixtures
  • Add code to remove generate libraries

snmaynard
snmaynard suggested changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@snmaynard snmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once my comment is dealt with, providing this passes I'm ok with it being merged

features/support/env.rb Show resolved Hide resolved
@Cawllec Cawllec changed the title (WIP): Update maze support Update maze support Nov 19, 2018
@Cawllec Cawllec mentioned this pull request Nov 19, 2018
Merged
15 tasks
@Cawllec Cawllec merged commit 42eb1ab into master Nov 21, 2018
@Cawllec Cawllec deleted the cawllec/update-maze-support branch November 21, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobyhs tobyhs tobyhs left review comments

@snmaynard snmaynard snmaynard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cawllec @snmaynard @tobyhs