Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated upgrading guide with log information #399

Merged
merged 2 commits into from
Nov 22, 2017

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Nov 21, 2017

Adds missing logging info regarding removal of Bugsnag logger functions, fixing #398

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.859% when pulling fb54d25 on cawllec/upgrading-update into 7323b6a on master.

UPGRADING.md Outdated
- Bugsnag.log "Log message"
- Bugsnag.warn "Warn message"
- Bugsnag.debug "Debug message"
+ Bugsnag.configuration.info "Info message"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say Bugsnag.configuration.logger.info is better for external users.

UPGRADING.md Outdated
@@ -56,3 +56,14 @@ guide](https://docs.bugsnag.com/api/deploy-tracking/capistrano/) for more inform
+ config.logger.level = Logger::DEBUG
end
```

* Log accessor functions on the `Bugsang` object no longer exist. Logging must now be accessed through the configuration object:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugsang -> Bugsnag

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.859% when pulling 9f72ce2 on cawllec/upgrading-update into 7323b6a on master.

@Cawllec Cawllec merged commit b7c7cb1 into master Nov 22, 2017
@Cawllec Cawllec deleted the cawllec/upgrading-update branch November 22, 2017 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants