Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 example updates #374

Merged
merged 38 commits into from
Oct 12, 2017
Merged

V6 example updates #374

merged 38 commits into from
Oct 12, 2017

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Oct 3, 2017

V6 Example Updates

This PR updates all of the current examples to work with the V6 ruby-notifier

Additions

  • Ensures examples work with next notifier version
  • Updates README.md for all examples
  • Ensures all examples demonstrate similar behaviour

Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great, especially the improved setup documentation in each example README.

@kattrali kattrali merged commit 38f2571 into v5 Oct 12, 2017
@kattrali kattrali deleted the v5-example-updates branch October 12, 2017 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants