Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'did you mean' suggestions middleware #372

Merged
merged 6 commits into from
Oct 2, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/bugsnag/configuration.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
require "bugsnag/middleware/callbacks"
require "bugsnag/middleware/exception_meta_data"
require "bugsnag/middleware/ignore_error_class"
require "bugsnag/middleware/suggestion_data"
require "bugsnag/middleware/classify_error"

module Bugsnag
Expand Down Expand Up @@ -74,6 +75,7 @@ def initialize
self.internal_middleware = Bugsnag::MiddlewareStack.new
self.internal_middleware.use Bugsnag::Middleware::ExceptionMetaData
self.internal_middleware.use Bugsnag::Middleware::IgnoreErrorClass
self.internal_middleware.use Bugsnag::Middleware::SuggestionData
self.internal_middleware.use Bugsnag::Middleware::ClassifyError

self.middleware = Bugsnag::MiddlewareStack.new
Expand Down
30 changes: 30 additions & 0 deletions lib/bugsnag/middleware/suggestion_data.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
module Bugsnag::Middleware
class SuggestionData

CAPTURE_REGEX = /Did you mean\?([\s\S]+)$/
DELIMITER = "\n"

def initialize(bugsnag)
@bugsnag = bugsnag
end

def call(report)
matches = []
report.raw_exceptions.each do |exception|
match = CAPTURE_REGEX.match(exception.message)
next unless match

suggestions = match.captures[0].split(DELIMITER)
matches.concat suggestions.map{ |suggestion| suggestion.strip }
end

if matches.size == 1
report.add_tab(:error, {:suggestion => matches.first})
elsif matches.size > 1
report.add_tab(:error, {:suggestions => matches})
end

@bugsnag.call(report)
end
end
end
36 changes: 35 additions & 1 deletion spec/middleware_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,41 @@ def call(report)
}
end

if ruby_version_greater_equal?("2.3.0")
context "with a ruby version >= 2.3.0" do
it "attaches did you mean metadata when necessary" do
begin
"Test".starts_with? "T"
rescue Exception => e
Bugsnag.notify(e)
end

expect(Bugsnag).to have_sent_notification{ |payload|
event = get_event_from_payload(payload)
expect(event["metaData"]["error"]).to_not be_nil
expect(event["metaData"]["error"]).to eq({"suggestion" => "start_with?"})
}
end
end
end

context "with a ruby version < 2.3.0" do
if !ruby_version_greater_equal?("2.3.0")
it "doesn't attach did you mean metadata" do
begin
"Test".starts_with? "T"
rescue Exception => e
Bugsnag.notify(e)
end

expect(Bugsnag).to have_sent_notification{ |payload|
event = get_event_from_payload(payload)
expect(event["metaData"]["error"]).to be_nil
}
end
end
end

it "doesn't allow handledState properties to be changed in middleware" do
HandledStateChanger = Class.new do
def initialize(bugsnag)
Expand Down Expand Up @@ -216,5 +251,4 @@ def call(report)
})
}
end

end
8 changes: 8 additions & 0 deletions spec/spec_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,14 @@ def notify_test_exception(*args)
Bugsnag.notify(RuntimeError.new("test message"), *args)
end

def ruby_version_greater_equal?(version)
current_version = RUBY_VERSION.split "."
target_version = version.split "."
(Integer(current_version[0]) >= Integer(target_version[0])) &&
(Integer(current_version[1]) >= Integer(target_version[1])) &&
(Integer(current_version[2]) >= Integer(target_version[2]))
end

RSpec.configure do |config|
config.order = "random"

Expand Down