-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added unhandled functionality, updated tests and integrations #368
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7e399e3
Added unhandled functionality, updated tests and intergrations
Cawllec 4e40c4b
Recombined auto_notify and notify, using auto_notify flag
Cawllec 5d0411e
Made unhandled & severity_reason fields uneditable by user
Cawllec 880affa
Changed auto_notifies to notify with auto_notify enabled
Cawllec cdb80c4
Removed auto-notify from integration test
Cawllec 2aa48ca
Tracking auto_notify in report to stop unhandled being set in manual …
Cawllec 4d1770d
Ensures handledState properties only set once
Cawllec a7799ee
Modified and added tests to reflect new layout
Cawllec 725f7f1
Added info error classifier middleware
Cawllec 7023dab
Updated integrations severityReasons
Cawllec 8cba071
Removed defaultSeverity and enabled modifying of severity-reason
Cawllec f7db8af
Added severityReason changes based on callbacks
Cawllec 9d4f95e
Updated to correct functions calls
Cawllec 391a755
updated tests
Cawllec 464ac7f
More sensible defaults in auto_notify cases
Cawllec 82519e3
Incorrect setting
Cawllec 085108c
Ensured Bugsnag refered to correctly as const
Cawllec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
module Bugsnag::Middleware | ||
class ClassifyError | ||
INFO_CLASSES = [ | ||
"AbstractController::ActionNotFound", | ||
"ActionController::InvalidAuthenticityToken", | ||
"ActionController::ParameterMissing", | ||
"ActionController::UnknownAction", | ||
"ActionController::UnknownFormat", | ||
"ActionController::UnknownHttpMethod", | ||
"ActiveRecord::RecordNotFound", | ||
"CGI::Session::CookieStore::TamperedWithCookie", | ||
"Mongoid::Errors::DocumentNotFound", | ||
"SignalException", | ||
"SystemExit" | ||
] | ||
|
||
def initialize(bugsnag) | ||
@bugsnag = bugsnag | ||
end | ||
|
||
def call(report) | ||
report.raw_exceptions.each do |ex| | ||
|
||
ancestor_chain = ex.class.ancestors.select { | ||
|ancestor| ancestor.is_a?(Class) | ||
}.map { | ||
|ancestor| ancestor.to_s | ||
} | ||
|
||
INFO_CLASSES.each do |info_class| | ||
if ancestor_chain.include?(info_class) | ||
report.severity_reason = { | ||
:type => Bugsnag::Report::ERROR_CLASS, | ||
:attributes => { | ||
:errorClass => info_class | ||
} | ||
} | ||
report.severity = 'info' | ||
break | ||
end | ||
end | ||
end | ||
|
||
@bugsnag.call(report) | ||
end | ||
end | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be declared as
attr_reader
, since its only being set internally by a method (I think that was the intent ofset_handled_states
). It would prevent accidental overrides by other code/callback writers.