Add support for DelayedJob Custom Job arguments #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattrali
reviewed
Apr 28, 2017
lib/bugsnag/delayed_job.rb
Outdated
| @@ -33,7 +33,8 @@ def error(job, error) | |||
| p[:id] = payload.id if payload.respond_to?(:id) | |||
| p[:display_name] = payload.display_name if payload.respond_to?(:display_name) | |||
| p[:method_name] = payload.method_name if payload.respond_to?(:method_name) | |||
| p[:args] = payload.args if payload.respond_to?(:args) | |||
| p[:args] = payload.respond_to?(:args) ? payload.args : payload.to_h | |||
There was a problem hiding this comment.
Where does to_h come from? I didn't see this mentioned in DelayedJob anywhere.
There was a problem hiding this comment.
@kattrali It's available as a method on the Struct class which is passed to Delayed::Job#enqueue. This outputs the parameters to that job in the form of a hash.
However I can see it might raise problems where the user has a Custom class that does not support this method, so I'll update it to not add args in such case. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for passing the arguments for Custom Job objects in the DelayedJob integration.
Please advise of the best way to handle writing any specs for this. I've tested it manually on various job types.