Support clearance similar to devise/warden #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @jrochkind! Taking a look now 👀 |
| user = {} | ||
| user_object = notification.request_data[:rack_env]["clearance"].current_user | ||
| if user_object | ||
| # Build the user info for this scope |
There was a problem hiding this comment.
is this a valid comment for clearance? Does it have scopes like warden?
There was a problem hiding this comment.
Clearance has no scopes, I'll remove the accidentally copy-pasted comments.
|
@jrochkind do we need to require |
kattrali
added
the
awaiting feedback
Clearance is a fairly popular alternative. https://github.com/thoughtbot/clearance
jrochkind
force-pushed
the
support_clearance
branch
from
6910b8d
to
d3859c0
Compare
|
Removed/fixed the accidentally copy-pasted comments from the devise/warden version. Added the missing Thanks! |
kattrali
removed
the
awaiting feedback
|
Looks good to me 👍 |
|
@jrochkind, I just made a little tweak to this and merged - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearance is a fairly popular alternative. https://github.com/thoughtbot/clearance