Make the list of vendor paths configurable #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -410,6 +410,17 @@ def stacktrace(exception) | |||
| end.compact | |||
| end | |||
|
|
|||
| def in_project?(line) | |||
| return nil if @configuration.vendor_paths && @configuration.vendor_paths.any? do |vendor_path| | |||
There was a problem hiding this comment.
I think we should return false here rather than nil to honour the ? convention in ruby.
There was a problem hiding this comment.
RIght. I'll fix this.
|
I think this is a sensible addition to the library and its a good call to make it backwards compat! 👍 |
snmaynard
added a commit
that referenced
this pull request
Aug 27, 2015
Make the list of vendor paths configurable
|
Thanks @byroot! |
|
Actually I think I should have included a doc update... |
|
Thats fine - I was going to throw something in there in a bit myself! |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the title explains it all. It allow to mark some part of the application as "framework", that shouldn't be used for grouping, nor title.
@loopj @snmaynard what do you think?