Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugsnag.clear_request_data not called after Sidekiq worker runs for Sidekiq versions >= 3 #306

Closed
tmak opened this issue Jul 7, 2016 · 2 comments
Closed

Bugsnag.clear_request_data not called after Sidekiq worker runs for Sidekiq versions >= 3 #306

tmak opened this issue Jul 7, 2016 · 2 comments

Comments

@tmak
Copy link

tmak commented Jul 7, 2016

Maybe I'm missing something here.
For Sidekiq versions >= 3 the middleware Bugsnag::Sidekiq is not used and because of that Bugsnag.clear_request_data is not called after Sidekiq worker runs.

I'm happy to create a PR if somebody else confirms this as a bug.
@martin308
Copy link
Contributor

Hi @tmak, as we don't call set_request_data in the code path when sidekiq version is >= 3 there is no need to call clear_request_data as the middleware does.

snmaynard added a commit that referenced this issue Aug 19, 2016
@snmaynard
Fixes #282, #309, #306
ff4fe4f
@snmaynard snmaynard mentioned this issue Aug 19, 2016
Merged
@snmaynard
Copy link
Contributor

I have just merged in a fix for this in #317 - will get a release out for it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmak @martin308 @snmaynard