Catch RackRequest crash while cleaning a URL

bugsnag · Apr 4, 2016 · 5cfae87 · 5cfae87
1 parent a31fb31
commit 5cfae87
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/lib/bugsnag/middleware/rack_request.rb b/lib/bugsnag/middleware/rack_request.rb
@@ -23,7 +23,13 @@ def call(notification)
         # Build the clean url (hide the port if it is obvious)
         url = "#{request.scheme}://#{request.host}"
         url << ":#{request.port}" unless [80, 443].include?(request.port)
-        url << Bugsnag::Cleaner.new(notification.configuration.params_filters).clean_url(request.fullpath)
+
+        # If app is passed a bad URL, this code will crash attempting to clean it
+        begin
+          url << Bugsnag::Cleaner.new(notification.configuration.params_filters).clean_url(request.fullpath)
+        rescue StandardError => stde
+          Bugsnag.log "RackRequest - Rescued error while cleaning request.fullpath: #{stde}"
+        end
 
         headers = {}