Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expo): Ensure types allow start() can be called with no arguments #817

Merged
merged 2 commits into from
Apr 24, 2020
Merged

fix(expo): Ensure types allow start() can be called with no arguments #817

merged 2 commits into from
Apr 24, 2020

Conversation

bengourley
Copy link
Contributor

The implementation of start() on Expo allows no arguments. This updates the types to reflect that.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Apr 24, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.28 kB 12.12 kB
After 39.28 kB 12.12 kB
± No change No change

Generated by 🚫 dangerJS against e1ecae2

@bengourley bengourley merged commit d1daac5 into release/v7.0.1 Apr 24, 2020
@bengourley bengourley deleted the type-expo-api-key-optional branch April 24, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

@twometresteve twometresteve Awaiting requested review from twometresteve

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @djskinner