V7: revert top level metadata #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bullmo
reviewed
Apr 6, 2020
bullmo
approved these changes
Apr 6, 2020
djskinner
approved these changes
Apr 6, 2020
Revert "refactor(types): Allow null section in event metadata" This reverts commit 23e3a02. Revert "refactor(types): Allow null metadata in types too" This reverts commit 1e2d8d2. Revert "docs: Update upgrading guide with top-level metadata" This reverts commit d0f3bb8. Revert "feat(core): Support adding top-level metadata" This reverts commit 526c897.
bengourley
force-pushed
the
v7-revert-top-level-metadata
branch
from
254a8d3
to
3184ed2
Compare
djskinner
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the feature that was added in #787, and provides guidance on how to maintain consistency with the display and custom filters after the upgrade.