Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7: Ensure context behaviour matches spec #694

Merged
merged 2 commits into from
Jan 8, 2020
Merged

V7: Ensure context behaviour matches spec #694

merged 2 commits into from
Jan 8, 2020

Conversation

bengourley
Copy link
Contributor

@bengourley bengourley commented Jan 3, 2020 •
edited
Loading

  • The automatic value should only be used if a manual value is not supplied (including if null is supplied)
  • The automatic value that will be used should be available in the onError callback so that the developer can inspect/change it

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jan 3, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.24 kB 12.47 kB
After 41.26 kB 12.47 kB
± ⚠️ +12 bytes ⚠️ +1 bytes

Generated by 🚫 dangerJS against a2aa041

@bengourley bengourley merged commit 98bc6fd into v7 Jan 8, 2020
@bengourley bengourley deleted the v7-context-spec branch January 8, 2020 15:10
@bengourley bengourley mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @djskinner