Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7: Tweak enabledReleaseStages logic #689

Merged
merged 3 commits into from
Jan 6, 2020
Merged

V7: Tweak enabledReleaseStages logic #689

merged 3 commits into from
Jan 6, 2020

Conversation

bengourley
Copy link
Contributor

Tweaks based on recent changes to the spec:

  • enabledReleaseStages should default to null
  • null should mean all release stages are enabled
  • empty array should mean no release stages are enabled

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Jan 2, 2020 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.63 kB 12.29 kB
After 40.64 kB 12.29 kB
± ⚠️ +5 bytes ⚠️ +6 bytes

Generated by 🚫 dangerJS against 86e15bd

@bengourley bengourley force-pushed the v7-enabled-release-stage-logic branch from 03ee047 to 86e15bd Compare January 3, 2020 14:30
@bengourley bengourley merged commit c4909e6 into v7 Jan 6, 2020
@bengourley bengourley deleted the v7-enabled-release-stage-logic branch January 6, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @tomlongridge