Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix params #687

Closed
wants to merge 4 commits into from
Closed

fix params #687

wants to merge 4 commits into from

Conversation

marktran
Copy link
Contributor

getRequestAndMetaDataFromReq is incorrectly nested inside createReportFromErr.

Koa plugin: https://github.com/bugsnag/bugsnag-js/blob/next/packages/plugin-koa/src/koa.js#L73

@mattdyoung
Copy link
Contributor

Hi @marktran

Thanks for the PR! We'll look at getting this reviewed and merged in due course.

@mattdyoung mattdyoung added the bug Confirmed bug label Jan 6, 2020
@bengourley bengourley mentioned this pull request Jan 6, 2020
Merged
@bengourley
Copy link
Contributor

I've reopened this in #695 so that our authenticated checks will run.

@bengourley bengourley closed this Jan 6, 2020
@marktran marktran deleted the fix-params branch January 6, 2020 15:58
@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Jan 7, 2020
@bengourley bengourley mentioned this pull request Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Confirmed bug scheduled Work is starting on this feature/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marktran @mattdyoung @bengourley @bugsnagbot