Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V7: event refactor #680

Merged
merged 6 commits into from
Dec 20, 2019
Merged

V7: event refactor #680

merged 6 commits into from
Dec 20, 2019

Conversation

bengourley
Copy link
Contributor

Mainly this PR updates Event to support multiple errors under the event.errors property.

It also has a general tidy up of the event's constructor, properties and types.

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Dec 19, 2019 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.35 kB 12.24 kB
After 40.45 kB 12.27 kB
± ⚠️ +96 bytes ⚠️ +31 bytes

Generated by 🚫 dangerJS against d53c4f3

djskinner
djskinner reviewed Dec 20, 2019
View reviewed changes
packages/core/types/event.d.ts Outdated Show resolved Hide resolved
packages/core/types/event.d.ts Outdated Show resolved Hide resolved
packages/core/types/event.d.ts Show resolved Hide resolved
packages/core/types/event.d.ts Show resolved Hide resolved
packages/plugin-node-in-project/in-project.js Show resolved Hide resolved
packages/plugin-strip-project-root/strip-project-root.js Show resolved Hide resolved
packages/core/event.js Show resolved Hide resolved
@bengourley bengourley merged commit 0bf0481 into v7 Dec 20, 2019
@bengourley bengourley deleted the v7-event-refactor branch December 20, 2019 11:46
@bengourley bengourley mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djskinner djskinner djskinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bengourley @bugsnagbot @djskinner