V7: Callback refactor #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djskinner
approved these changes
Dec 9, 2019
packages/core/test/client.test.js
Outdated
| expect(sSpy).toHaveBeenCalledTimes(1) | ||
| c.notify(new Error(), () => {}, () => { | ||
| expect(bSpy).toHaveBeenCalledTimes(1) | ||
| expect(bSpy).toHaveBeenCalledTimes(1) |
packages/core/test/client.test.js
Outdated
| expect(sSpy).toHaveBeenCalledTimes(1) | ||
| c.notify(new Error(), () => {}, () => { | ||
| expect(bSpy).toHaveBeenCalledTimes(1) | ||
| expect(bSpy).toHaveBeenCalledTimes(1) |
There was a problem hiding this comment.
Good spot – this was actually meant to make an assertion about eSpy.
packages/core/client.js
Outdated
| this._logger.error('Error occurred in onSession callback, continuing anyway…') | ||
| this._logger.error(e) | ||
| } | ||
| } |
There was a problem hiding this comment.
This could be refactored although it doesn't help to reduce the bundle diff:
runSyncCallbacks (callbacks, callbackArg, callbackType) {
let ignore = false
const cbs = callbacks.slice(0)
while (!ignore) {
if (!cbs.length) break
try {
ignore = cbs.pop()(callbackArg) === false
} catch (e) {
this._logger.error(`Error occurred in ${callbackType} callback, continuing anyway…`)
this._logger.error(e)
}
}
return ignore
}
There was a problem hiding this comment.
I'll take this – we can reuse it for the internal session payload callbacks too.
djskinner
approved these changes
Dec 9, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onBreadcrumbandonSessionbreadcrumbsonSessionPayloadbreadcrumbs (will be required by a subsequent PR for attaching data to a session)