V7: Metadata refactor #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bengourley
force-pushed
the
v7-metadata-refactor
branch
2 times, most recently
from
0121ff2
to
0673f15
Compare
bengourley
force-pushed
the
v7-metadata-refactor
branch
from
0673f15
to
30718ae
Compare
bengourley
force-pushed
the
v7-metadata-refactor
branch
from
30718ae
to
75de94c
Compare
djskinner
reviewed
Dec 2, 2019
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ | |||
| - Update signature of `notify(err, opts?, cb?)` -> `notify(err, onError?, cb?)` for a canonical way to update events [#655](https://github.com/bugsnag/bugsnag-js/pull/655) | |||
| - Simplify client configuration, and store resulting config privately [#656](https://github.com/bugsnag/bugsnag-js/pull/656) | |||
| - User is now stored privately on `client` and `event` and updated via get/set methods [#657](https://github.com/bugsnag/bugsnag-js/pull/657) | |||
| - Rename `metaData` -> `metadata` and add consistent `add/get/clearMetaData()` methods to `Client`/`Event` for manipulating metadata explicitly, rather than mutating a property [#658](https://github.com/bugsnag/bugsnag-js/pull/658) | |||
There was a problem hiding this comment.
add/get/clearMetaData() -> add/get/clearMetadata()
packages/core/test/event.test.js
Outdated
| }) | ||
| }) | ||
|
|
||
| describe('event.clearMetadata()', () => { |
There was a problem hiding this comment.
describe('event.clearMetadata()' -> describe('event.addMetadata()'
Comment on lines
-97
to
-105
| export interface NotifyOpts { | ||
| context?: string; | ||
| device?: object; | ||
| request?: object; | ||
| user?: object; | ||
| metaData?: object; | ||
| severity?: "info" | "warning" | "error"; | ||
| onError?: OnError; | ||
| } |
There was a problem hiding this comment.
Is this removal intended as part of this PR?
There was a problem hiding this comment.
Can leave it in this PR for me, just wanted to be sure it was right.
djskinner
approved these changes
Dec 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metaData->metadata_metadataand remove from the public interfaceadd/get/clearMetadata()methods via a shared delegate toEventandClient