Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notify's 3rd argument type #518

Closed
wants to merge 1 commit into from

Conversation

deanmraz
Copy link

@deanmraz deanmraz commented Apr 8, 2019

Issue

  • Typescript is unaware of 3rd argument

Goal

  • Add 3rd argument to typescript definition

Code

notify (error, opts = {}, cb = () => {}) {

@bengourley
Copy link
Contributor

This is fixed in #515 which is due to land soon. Thanks!

@bengourley bengourley closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants