Add React Navigation tests to dynamic fixture setup #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Incorporates the React Navigation test scenarios into the new scenario launcher package and dynamic test fixture setup.
Design
These scenarios now run as part of the regular React Native test matrix, so they're now running for all RN versions from 0.71 onwards (previously we had no navigation tests for these versions)
It also means that separate build/CI steps are no longer required for these tests, so they'll automatically get run when new React Native versions are added to the text matrix.
New Architecture support in React Navigation itself is patchy at best, so these tests are skipped if New Architecture is enabled.
Testing
covered by a full CI run