Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(react-native): fix react-navigation 0.69 test fixture builds #2196

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

yousif-bugsnag
Copy link
Contributor

Goal

Fixes the react-navigation 0.69 test fixture builds in CI

The test fixture was configured to install the latest v2 version of react-native-gesture-handler, and it looks like something in the latest release (which coincides with when these builds began failing) has broken compatibility with RN 0.69.

Updated the build script to pin the dependency to the last known working version.

Testing

Covered by a full CI run

Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.24 kB 13.74 kB
After 45.24 kB 13.74 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 1a23061

@gingerbenw
Copy link
Member

👌🏻 excellent detective work!

@yousif-bugsnag yousif-bugsnag merged commit 512ac27 into next Sep 13, 2024
133 checks passed
@yousif-bugsnag yousif-bugsnag deleted the PLAT-12730/fix-rn-navigation-069-build branch September 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants