Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAT-12474] Support error correlation property in events #2174

Merged
merged 3 commits into from
Jul 24, 2024
Merged

[PLAT-12474] Support error correlation property in events #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b03417
feat: :sparkles: add correlation property to eventPayload
gingerbenw Jul 22, 2024
d15e41d
test: :test_tube: test correlation property in delivery
gingerbenw Jul 23, 2024
4c1af12
access `event._correlation` without use of .toJSON method
gingerbenw Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## [8.0.0] - Unreleased

### Added

- (delivery-react-native) Support error correlation properties in event payloads [#2174](https://github.com/bugsnag/bugsnag-js/pull/2174)

### Fixed

- (plugin-angular) Prevent excess change detection cycles when calling `Bugsnag.notify` [#1861](https://github.com/bugsnag/bugsnag-js/pull/1861)
Expand Down
3 changes: 2 additions & 1 deletion packages/delivery-react-native/delivery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ module.exports = (client, NativeClient) => ({
groupingHash: event.groupingHash,
apiKey: event.apiKey,
featureFlags: event.toJSON().featureFlags,
nativeStack: nativeStack
nativeStack: nativeStack,
correlation: event._correlation
}

if (isTurboModuleEnabled) {
Expand Down
3 changes: 3 additions & 0 deletions packages/delivery-react-native/test/delivery.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ type NativeClientEvent = Pick<EventWithInternals,
severityReason: EventWithInternals['_handledState']['severityReason']
user: EventWithInternals['_user']
metadata: EventWithInternals['_metadata']
correlation: EventWithInternals['_correlation']
nativeStack: NativeStackIOS | NativeStackAndroid
}

Expand Down Expand Up @@ -57,6 +58,7 @@ describe('delivery: react native', () => {
c.setContext('test screen')
c.setUser('123')
c.notify(new Error('oh no'), (e) => {
e.setTraceCorrelation('trace-id', 'span-id')
e.groupingHash = 'ER_GRP_098'
e.apiKey = 'abcdef123456abcdef123456abcdef123456'
}, (err, event) => {
Expand All @@ -80,6 +82,7 @@ describe('delivery: react native', () => {
expect(sent[0].metadata).toEqual({})
expect(sent[0].groupingHash).toEqual('ER_GRP_098')
expect(sent[0].apiKey).toBe('abcdef123456abcdef123456abcdef123456')
expect(sent[0].correlation).toEqual({ traceId: 'trace-id', spanId: 'span-id' })
done()
})
})
Expand Down
Loading