Check global vue config exists before installing vue 2 handler #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
force-pushed
the
PLAT-12245/vue-3-global-fix
branch
from
a6770f2
to
69e59db
Compare
gingerbenw
reviewed
Jul 12, 2024
| @@ -16,7 +16,7 @@ module.exports = class BugsnagPluginVue { | |||
| } | |||
|
|
|||
| load (client) { | |||
| if (this.Vue) { | |||
| if (this.Vue && this.Vue.config) { | |||
There was a problem hiding this comment.
any particular reason not to check against the vue version? we could even use a switch statement to make supporting new versions easier
There was a problem hiding this comment.
Well the global Vue.config was removed in v3, but I just thought it made more sense to check if the required API exists rather than check for a particular version.
Really either way would work - and I guess the plugin is already 'versioned' so happy to change to a version check if you think a would be better.
There was a problem hiding this comment.
fair point. API over version. 👍🏻
gingerbenw
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fixes an error in the Vue plugin initialisation when using Vue 3+ via CDN (reported in #2150)
Design
Currently the plugin attempts to install the Vue 2 handler (via the global Vue.config) if a global Vue object exists, but CDN builds of Vue 3+ will also expose a global Vue object.
This PR updates the check in plugin load to ensure that Vue.config exists before installing the Vue 2 handler.
Testing
Added a new unit test and tested manually with a Vue 3 CDN build.