Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure client is initialised synchronously in bridgeless mode #2165

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Ensure client is initialised synchronously in bridgeless mode #2165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
### Fixed

- (react-native) Use synchronous native module calls when New Architecture is enabled [#2152](https://github.com/bugsnag/bugsnag-js/pull/2152)
- (react-native) Ensure client is initialised synchronously in bridgeless mode [#2165](https://github.com/bugsnag/bugsnag-js/pull/2165)

## [7.24.0] - 2024-06-10

Expand Down
4 changes: 2 additions & 2 deletions packages/react-native/src/notifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ This only affects the remote debugger. Execution of JS in the normal way (on the

// this is how some internal react native code detects whether the app is running
// in the remote debugger:
// https://github.com/facebook/react-native/blob/1f4535c17572df78e2a033890220337e5703b614/Libraries/ReactNative/PaperUIManager.js#L62-L66
// https://github.com/facebook/react-native/blob/e320ab47cf855f2e5de74ea448ec292cf0bbb29a/packages/react-native/Libraries/Utilities/DebugEnvironment.js#L15
// there's no public api for this so we use the same approach
const isDebuggingRemotely = !global.nativeCallSyncHook
const isDebuggingRemotely = !global.nativeCallSyncHook && !global.RN$Bridgeless

const name = 'Bugsnag React Native'
const { version } = require('../package.json')
Expand Down
Loading