add node 20 to e2e test pipeline #2106
Conversation
This reverts commit 543984a.
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "bugsnag-test", | |||
| "dependencies": { | |||
| "restify": "^7.2.1", | |||
| "restify": "^11.1.0", | |||
There was a problem hiding this comment.
works on node 18 and 20 but no longer on node 12
| @@ -29,15 +29,15 @@ server.use(function (req, res, next) { | |||
| next() | |||
| }) | |||
|
|
|||
| server.get('/', function (req, res) { | |||
| server.get('/', function (req, res, next) { | |||
There was a problem hiding this comment.
Fix these runtime errors:
AssertionError [ERR_ASSERTION]: Handler [handler-1 on GET /sync/:message] is missing a third argument (the "next" callback) but is not an async function. Middleware handlers can be either async/await or callback-based.Callback-based (non-async) handlers should accept three arguments: (req, res, next). Async handler functions should accept maximum of 2 arguments: (req, res).
| @@ -1,4 +1,4 @@ | |||
| @skip_node_18 | |||
| @skip_node_12 | |||
There was a problem hiding this comment.
new restify version doesn't work on 12 because of a syntax error:
/Users/dan.skinner/bugsnag-js/test/node/features/fixtures/restify/node_modules/sonic-boom/index.js:393
cb?.()
| optimization: { | ||
| minimize: false, |
There was a problem hiding this comment.
any version of webpack 4 on node 20 fails with Error message "error:0308010C:digital envelope routines::unsupported" to do with changes to lib ssl version being used by an older version of the terser plugin that comes with webpack. To work around this just disable minification as it's not necessary for our testing
| @@ -1,4 +1,4 @@ | |||
| @skip_node_18 | |||
There was a problem hiding this comment.
18 was failing for the same reason as 20 (restify needed bumping) and it had been disabled a while back with the intention of coming back and fixing it, but that was forgotten about until now
There was a problem hiding this comment.
looks good to me - while we're skipping node 12 in a few places, is this a good time to raise whether we actually should still support it @tomlongridge ? I believe it went out of support in April 2022
No description provided.