Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update v8 peer dependency range to match alpha releases #2100

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

djskinner
Copy link
Contributor

@djskinner djskinner commented Mar 20, 2024

Goal

Fix npm install error when installing @bugsnag/plugin-express version 8: No matching version found for @bugsnag/core@^8

$ npm i
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @bugsnag/plugin-express@8.0.0-alpha.3
npm WARN Found: @bugsnag/core@8.0.0-alpha.3
npm WARN node_modules/@bugsnag/core
npm WARN   @bugsnag/core@"^8.0.0-alpha.3" from @bugsnag/browser@8.0.0-alpha.3
npm WARN   node_modules/@bugsnag/browser
npm WARN     @bugsnag/browser@"^8.0.0-alpha.3" from @bugsnag/js@8.0.0-alpha.3
npm WARN     node_modules/@bugsnag/js
npm WARN   1 more (@bugsnag/node)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @bugsnag/core@"^8" from @bugsnag/plugin-express@8.0.0-alpha.3
npm WARN node_modules/@bugsnag/plugin-express
npm WARN   @bugsnag/plugin-express@"8.0.0-alpha.3" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @bugsnag/plugin-express@8.0.0-alpha.3
npm WARN Found: @bugsnag/core@undefined
npm WARN node_modules/@bugsnag/core
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer @bugsnag/core@"^8" from @bugsnag/plugin-express@8.0.0-alpha.3
npm WARN node_modules/@bugsnag/plugin-express
npm WARN   @bugsnag/plugin-express@"8.0.0-alpha.3" from the root project
npm ERR! code ETARGET
npm ERR! notarget No matching version found for @bugsnag/core@^8.
npm ERR! notarget In most cases you or one of your dependencies are requesting
npm ERR! notarget a package version that doesn't exist.

Before:

Screenshot 2024-03-20 at 14 54 16

After:

Screenshot 2024-03-20 at 14 54 31

Testing:

  • publish a new alpha release to confirm issue is resolved

Copy link

github-actions bot commented Mar 20, 2024

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 44.74 kB 13.64 kB
After 44.74 kB 13.64 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against b15f5b9

@djskinner djskinner merged commit cda556c into integration/v8 Mar 21, 2024
74 of 79 checks passed
@djskinner djskinner deleted the v8-peer-deps branch March 21, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants