Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 stage builds #1997

Merged
merged 6 commits into from
Aug 14, 2023
Merged

2 stage builds #1997

merged 6 commits into from
Aug 14, 2023

Conversation

yousif-bugsnag
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag commented Aug 1, 2023

Goal

Reduces CI bottlenecks by pushing the majority of React Native and RN CLI tests into a separate 'full' build pipeline

Design

Followed the same approach as the js performance repo. Full builds can be triggered for builds of next or main, with the commit message [full ci], or interactively via the buildkite UI.

All React Native & CLI tests except those for the latest version (RN 0.72 old and new arch) have been moved to the full build.

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.67 kB 13.40 kB
After 43.67 kB 13.40 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 72a40c0

@twometresteve
Copy link
Contributor

You've followed the existing pattern perfectly by putting .full. in the filenames, but with the number of pipeline files now in the repo, it's hard to navigate them in a tree view. Could we either organise them into basic and full subdirectories underneath .buildkite, or bring the full. in each filename to the front so that they all appear together? I.e. full.pipeline.yml, full.react-native-android-pipeline.yml etc.


if [[ "$BUILDKITE_MESSAGE" == *"[full ci]"* ||
"$BUILDKITE_BRANCH" == "next" ||
"$BUILDKITE_BRANCH" == "main" ||
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS is still using master, so suggest this for future proofing:

Suggested change
"$BUILDKITE_BRANCH" == "main" ||
"$BUILDKITE_BRANCH" == "main" ||
"$BUILDKITE_BRANCH" == "master" ||

Copy link
Contributor

@twometresteve twometresteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, the branch name comment is the main (or do I mean master?) one to get in.

Base automatically changed from PLAT-10600/rn-072-tests to next August 11, 2023 10:31
@yousif-bugsnag yousif-bugsnag merged commit e9f879f into next Aug 14, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants