Adapt Android RN test fixture to work with BitBar #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cawllec
changed the title
Cawllec
commented
May 11, 2023
| notifyEndpoint = endpointsIn[@"notify"]; | ||
| sessionsEndpoint = endpointsIn[@"sessions"]; | ||
| } else { | ||
| NSString *baseAddress = @"bs-local.com:9339"; |
There was a problem hiding this comment.
This will be replaced with the file loading logic in the below swift file once it can be compiled correctly
gingerbenw
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This is a required change for Android test fixtures to run using BitBar as a device farm under our current setup. Cocoa was initially in scope, but is being omitted as further work is required.
Design
The logic to read the files is pulled directly from equivalent test fixtures used in the Android and Cocoa repos. Instead of passing maze-runner addresses up to the top RN layer, instead the fixture will test to see if a specific notify/session endpoint has been input when starting BugSnag, only attempting to read from the config file if one hasn't been set.
This keeps all logic in the native layer, requiring minimal changes in JS or interaction between the code layers.
Testing
The tests will be independently updated to target BitBar as a device farm provider, although I intend to move one of the current test runs over as evidence of the change working successfully. In addition, manual testing will be performed to ensure the real dashboard and user-input options for BugSnag endpoints work as expected.