Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Buildkite build matrices for browser and node pipelines #1955

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Use Buildkite build matrices for browser and node pipelines #1955

merged 3 commits into from
Apr 25, 2023

Conversation

twometresteve
Copy link
Contributor

Goal

Reduce the number of lines of YAML in the Buildkite pipeline by utilising build matrices.

Design

For now I have just tackled the Node and Browser sub-pipelines as the lowest hanging fruit.

Testing

Covered by CI.

@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.65 kB 13.39 kB
After 43.65 kB 13.39 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 6273b16

gingerbenw
gingerbenw approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@gingerbenw gingerbenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and clean 👌🏻

@twometresteve twometresteve merged commit 05588a1 into next Apr 25, 2023
@twometresteve twometresteve deleted the tms/build-matrices branch April 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gingerbenw gingerbenw gingerbenw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twometresteve @gingerbenw