Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-6697] Prevent excess change detection cycles #1861

Merged
merged 8 commits into from
Nov 9, 2022

Commits on Nov 4, 2022

  1. perf: ⚡ run client._notify in zone when available

    monkey patch the client._notify method to run in zone where applicable, preventing unnecessary change detection cycles
    
    Updating the UI within the onError callback will no longer be considered reliable
    gingerbenw committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    30d8a28 View commit details
    Browse the repository at this point in the history
  2. update CHANGELOG.md

    gingerbenw committed Nov 4, 2022
    Configuration menu
    Copy the full SHA
    ae536e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c4bca92 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. Apply suggestions from code review

    Co-authored-by: Joe Haines <hello@joehaines.co.uk>
    gingerbenw and imjoehaines committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    adb444a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    10ed91d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2022

  1. Update packages/plugin-angular/src/index.ts

    use all arguments when monkey patching
    
    Co-authored-by: Joe Haines <hello@joehaines.co.uk>
    gingerbenw and imjoehaines committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f21e295 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    094a27a View commit details
    Browse the repository at this point in the history
  3. fix ts issue

    gingerbenw committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    bae0faf View commit details
    Browse the repository at this point in the history