Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add JCenter dependency when building RN apps #1856

Merged
merged 8 commits into from
Nov 1, 2022

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Oct 31, 2022

Goal

Respond to yesterday's JCenter outage.

Design

The intention of the code in packages/react-native/android/build.gradle was to shield our test fixture builds from JCenter outages, but it also unnecessarily adding a dependency on JCenter for app builds in general.

Changeset

The build script snippet is now moved to only reside within our test fixture build scripts. The get all fixtures to build on CI during the (potentially partial) outage I found it necessary to replace jcenter() with mavenCentral() in a number of locations, as well as removing Flipper from the builds (we don't need it anyway).

Testing

Covered by CI.

@github-actions
Copy link

github-actions bot commented Oct 31, 2022

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 43.19 kB 13.21 kB
After 43.19 kB 13.21 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against d6f9d08

@twometresteve twometresteve changed the title Handle JCenter outage Do not add JCenter dependency to notifier build Nov 1, 2022
@twometresteve twometresteve marked this pull request as ready for review November 1, 2022 08:53
@twometresteve twometresteve changed the title Do not add JCenter dependency to notifier build Do not add JCenter dependency when building RN apps Nov 1, 2022
Copy link
Member

@gingerbenw gingerbenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's building and passing I'm happy - but review from @lemnik would be appreciated.

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twometresteve twometresteve merged commit 314234a into next Nov 1, 2022
@twometresteve twometresteve deleted the tms/jcenter-woes branch November 1, 2022 09:42
@gingerbenw gingerbenw mentioned this pull request Nov 1, 2022
@luke-belton luke-belton mentioned this pull request Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants