Remove Kotlin requirement from react-native #1750
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid version conflicts between the
react-native
project, the Android Gradle Plugin and Kotlin Gradle PluginDesign
Replaced the Kotlin layer in the
react-native
project with plain Java, which has no strict Gradle plugin dependency. Using bounded or wildcard dependencies results in older versions of Gradle being unable to run the build because the Kotlin Gradle Plugin used will be too new. Relying on other build scripts to import their expected version of the Kotlin plugin doesn't work if no other modules require Kotlin.The
react-native
module has very little real logic (most is in bugsnag-plugin-react-native), which makes this a relatively lightweight change.Testing
Relied on existing tests