Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kotlin requirement from react-native #1750

Merged
merged 1 commit into from
May 26, 2022

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented May 25, 2022

Goal

Avoid version conflicts between the react-native project, the Android Gradle Plugin and Kotlin Gradle Plugin

Design

Replaced the Kotlin layer in the react-native project with plain Java, which has no strict Gradle plugin dependency. Using bounded or wildcard dependencies results in older versions of Gradle being unable to run the build because the Kotlin Gradle Plugin used will be too new. Relying on other build scripts to import their expected version of the Kotlin plugin doesn't work if no other modules require Kotlin.

The react-native module has very little real logic (most is in bugsnag-plugin-react-native), which makes this a relatively lightweight change.

Testing

Relied on existing tests

@lemnik lemnik force-pushed the PLAT-8461/react-native-kotlin-version branch from 6cc2b52 to 3ce12a3 Compare May 25, 2022 15:40
@github-actions
Copy link

github-actions bot commented May 25, 2022

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 42.48 kB 12.99 kB
After 42.48 kB 12.99 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 871fab4

@lemnik lemnik marked this pull request as ready for review May 25, 2022 15:59
@lemnik lemnik force-pushed the PLAT-8461/react-native-kotlin-version branch from 3ce12a3 to 2c07ece Compare May 26, 2022 16:35
@lemnik lemnik force-pushed the PLAT-8461/react-native-kotlin-version branch from 2c07ece to 871fab4 Compare May 26, 2022 16:51
@lemnik lemnik merged commit c42bee8 into next May 26, 2022
@lemnik lemnik deleted the PLAT-8461/react-native-kotlin-version branch May 26, 2022 18:12
@gingerbenw gingerbenw mentioned this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants