Update react-native cli test fixture versions #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's an issue with the 0.66 fixture, it's consistently failing here: https://buildkite.com/bugsnag/bugsnag-js-react-native-cli/builds/2069#366823ef-addc-4e89-afa2-25155166d636/378-396 |
Yeah, I'd typo'd a reference in the docker file, that's fixed now |
imjoehaines
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Update the tested versions of react-native in the react-native-cli tests to ensure we have coverage up to the newest release of react-native. 0.60 is still our baseline and each version between that and the latest (0.67) will have tests run against them, including an ejected Expo app and an app running on the Hermes engine.
Since there are a large amount of file changes, I would advise reviewing each commit individually.