Fix a crash when XMLHttpRequest URL isn't a string #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.54 kB |
12.79 kB |
| After | 41.58 kB |
12.80 kB |
| ± | +42 bytes |
+9 bytes |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| ✅ | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-network-breadcrumbs/network-breadcrumbs.js | 98.78% (+0.03%) |
90.38% (+0.8%) |
100% (+0%) |
98.84% (+0.03%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.05%(+0%) | 71.91%(+0.05%) | 83.26%(+0%) | 81.11%(+0.01%) |
imjoehaines
force-pushed
the
fix-network-breadcrumb-crash
branch
from
44d4457
to
2d5382d
Compare
e.g. a HTMLAnchorElement returns its 'href' from 'toString', which allows it to be used in place of a URL string
imjoehaines
force-pushed
the
fix-network-breadcrumb-crash
branch
from
2d5382d
to
1e8b8e0
Compare
djskinner
approved these changes
Nov 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
An
XMLHttpRequestcan be passed any object that returns a URL from itstoStringmethod. For example, aHTMLAnchorElementreturns itshrefand so can be passed toXMLHttpRequest.open(obviously other values can also be passed, but they wouldn't lead to a valid URL so the request wouldn't work)This PR allows us to handle this case as previously we assumed the URL was a string. As Bugsnag endpoints must be strings we don't try to convert an object into a string, because we would never send a request with any other value in the first place