Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all e2e tests to use Maze Runner v6 #1555

Merged
merged 8 commits into from
Oct 27, 2021
Merged

Update all e2e tests to use Maze Runner v6 #1555

merged 8 commits into from
Oct 27, 2021

Conversation

twometresteve
Copy link
Contributor

@twometresteve twometresteve commented Oct 27, 2021

Goal

Update all Maze Runner setup to use v6.

Design

Largely follows the document process for upgrading MAze Runner from v4/v5.

Changeset

I found that the newer version of Maze Runner (or possible Cucumber that's wrapped in it) objected to multiple uses of the -e switch for Node. Rather than try to solve that, I updated the mechanism to use feature/scenarios tags of the form @skip_before_node_8. This approach is consistent with several of our other repos and I have checked that the same number of scenarios run for each version of Node before and after the change.

Testing

Covered by CI.

@github-actions
Copy link

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.24 kB 12.71 kB
After 41.24 kB 12.71 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 1b4ca23

@twometresteve twometresteve merged commit 5ee330e into next Oct 27, 2021
@imjoehaines imjoehaines deleted the tms/maze-v6 branch December 20, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants