Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-native): Only include codeBundleId in payload when it has a value #1426

Merged
merged 1 commit into from
Jun 7, 2021
Merged

fix(react-native): Only include codeBundleId in payload when it has a value #1426

merged 1 commit into from
Jun 7, 2021

Conversation

bengourley
Copy link
Contributor

Makes the behaviour of this field consistent with Electron in that it only appears in the payload if it has a value.

@bengourley bengourley requested a review from lemnik June 2, 2021 16:08
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.14 kB 12.66 kB
After 41.14 kB 12.66 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 9a7ad89

lemnik
lemnik approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bengourley bengourley merged commit d7f4adf into next Jun 7, 2021
@bengourley bengourley deleted the bengourley/rn-codebundleid-default branch June 7, 2021 08:56
@bengourley bengourley mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemnik lemnik lemnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bengourley @lemnik