fix(react-native): Copy RN's internal logging for unhandled rejections #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 41.14 kB |
12.66 kB |
| After | 41.14 kB |
12.66 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-react-native-unhandled-rejection/rejection-handler.js | 84.21% (-15.79%) |
62.5% (-19.32%) |
100% (+0%) |
86.36% (-13.64%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 82.32%(-0.05%) | 71.67%(-0.12%) | 83.42%(-0.02%) | 81.36%(-0.04%) |
bengourley
force-pushed
the
bengourley/rn-dev-console-warn-format
branch
from
f90b3ce
to
4c948ca
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevent duplicate log lines for promise rejection warnings in development (as observed in #1311 (comment)).
Design
The previous implementation copied logic from the
promisemodule – however, in development, RN used a customonUnhandledcallback which logged out once, rather than once per stackframe. This solution copies the RN internal logic, instead of thepromiselibrary default.