fix(expo): Ensure Expo plugins depend on same version of NetInfo package #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
reviewed
Mar 2, 2021
There was a problem hiding this comment.
I think 5.9.7 is right as it's what Expo SDK 40 uses — https://github.com/expo/expo/blob/45dd06df4c3d844e8adf774207d64015e76ec902/packages/expo/bundledNativeModules.json#L3
bengourley
force-pushed
the
bengourley/netinfo-version
branch
from
0eaf1d0
to
1ae9340
Compare
imjoehaines
approved these changes
Mar 2, 2021
|
My bad – I was trawling through the Expo repo since they don't tag their releases, and missed that 40 was already out. Changed and rebased. |
Merged
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the plugins used by
@bugsnag/expoall depend on the same version of NetInfo. Expo 40 depends on v5.9.7.I also updated the CONTRIBUTING.md guide because it was missing the connectivity breadcrumbs package.