fix: Xcode 12 compatibility #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋. Hey @nvojnovic, thanks for raising this with us, looks good, we're going to run this through CI and look into getting the changes merged in 😄 |
xljones
added
backlog
nvojnovic
force-pushed
the
nvojnovic-xcode12-fix
branch
from
bb51a12
to
6d3439f
Compare
|
Will this ever be merged? |
|
This was delayed whilst we were agreeing on a CI approach. It should now be merged soon. Thanks! |
|
This is now released in v7.9.6. Thanks for the contribution! |
mattdyoung
added
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Latest Xcode 12 fails to build while without a module to depend on
React-Coredirectly hence this change is necessary for all native modules on iOS. For more details please check: facebook/react-native#29633 (comment)Testing
Use this branch to install with an app running on Xcode 12.