-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-5950] Store source maps in $TMPDIR during Xcode build phases #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdowell
force-pushed
the
nickdowell/fix-rn-xcode-source-map-path
branch
from
February 11, 2021 13:11
8069d1a
to
9c50373
Compare
nickdowell
force-pushed
the
nickdowell/fix-rn-xcode-source-map-path
branch
from
February 11, 2021 13:41
9c50373
to
e74ec6f
Compare
# Conflicts: # test/react-native-cli/features/steps/steps.rb
nickdowell
changed the title
[PLAT-5950] Read source map from TMPDIR in Xcode build phase
[PLAT-5950] Store source maps in $TMPDIR during Xcode build phases
Feb 16, 2021
bengourley
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested with a project set up with the old version of the cli, using the new version of the notifier and it falls back nicely.
Just needs a changelog entry.
xljones
pushed a commit
that referenced
this pull request
Jul 27, 2021
xljones
pushed a commit
that referenced
this pull request
Jul 27, 2021
(fix)changelog: retroactively add changelog for #1289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Fix building projects whose build directory path contains whitespace.
The underlying issue is that react native's script cannot accept any paths containing spaces in
$EXTRA_PACKAGER_ARGS
Design
A new location has been designated for the source map:
$TMPDIR/$UID-main.jsbundle.map
This path is guaranteed to not contain any whitespace, which will fix compatibility with
react-native-xcode.sh
Use
md5
to generate a unique$UID
from the build path; unique for that project, build configuration and target.The script will fall back to the previous location to remain compatible with the old source map location, for Xcode projects that have not been updated.
Testing
Manually tested using sample RN projects.
Tested by following instructions from #1140 against a freshly created react native app.