[PLAT-5357] fix(react-native): Ensure plugin usage does not crash debugger #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjoehaines
reviewed
Jan 19, 2021
| createClientAsync(opts).then(client => { | ||
| initialised = true | ||
| Bugsnag._client = client | ||
| return Reflect.apply(target, thisArg, args) |
There was a problem hiding this comment.
Should this still be applying to Bugsnag._client if it has initialised?
There was a problem hiding this comment.
Yeah it has to carry being functional because plugins created and obtained synchronously still have a reference to that stubbed client. If we stopped apply()ing and no-op'ing, it could fail due to a plugin expecting it to return something.
bengourley
commented
Jan 19, 2021
| stubClient[m] = new Proxy(stubClient[m], { | ||
| apply: (target, thisArg, args) => { | ||
| if (!initialised) { | ||
| console.log(`Synchronous call to Bugsnag.${m}()`) |
There was a problem hiding this comment.
I changed this to a log rather than a warn, so that it doesn't pop up in the app's yellowbox UI.
imjoehaines
approved these changes
Jan 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
When run in the debugger, the React Native notifier starts asynchronously due to synchronous calls to native not being available in the debugging environment.
The existing workaround involved creating a no-op stubbed client interface, which covered most use cases, but not plugins where the return value of
Bugsnag.getPlugin('<name>')was required, resulting in the following bugs: #1143 #1112.Design
The new solution is to create an actual
Clientinstance so that plugins can be used in the short delay before the notifier starts properly.Changeset
Testing
The changes were manually tested in the remote debugger on an app using React Navigation.