Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(react-native): Bump bugsnag-cocoa to v6.5.0 #1225

Merged
merged 3 commits into from
Jan 7, 2021
Merged

deps(react-native): Bump bugsnag-cocoa to v6.5.0 #1225

merged 3 commits into from
Jan 7, 2021

Conversation

nickdowell
Copy link
Contributor

  • Updates bugsnag-cocoa to v6.5.0
  • Updates BugsnagReactNative to use new private header files instead of redeclaring @interfaces - this has revealed some APIs that are not yet exposed in the private headers, which will be addressed in the future.

@github-actions
Copy link

github-actions bot commented Jan 6, 2021 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 9547f8e

bengourley
bengourley suggested changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a changelog entry.

bengourley
bengourley suggested changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the changelog entry went under 7.5.5 which is a release that went out in December?

Can you add a new slot at the top of the file instead?

@nickdowell nickdowell force-pushed the nickdowell/bugsnag-cocoa-v6.5.0 branch from 0d9c2ed to b7d4085 Compare January 7, 2021 11:19
@nickdowell nickdowell force-pushed the nickdowell/bugsnag-cocoa-v6.5.0 branch from b7d4085 to 9547f8e Compare January 7, 2021 11:21
@nickdowell nickdowell merged commit c3e647b into next Jan 7, 2021
@nickdowell nickdowell deleted the nickdowell/bugsnag-cocoa-v6.5.0 branch January 13, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @bengourley