Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expo SDK 40 support #1219

Merged
merged 5 commits into from
Jan 6, 2021
Merged

Expo SDK 40 support #1219

merged 5 commits into from
Jan 6, 2021

Conversation

imjoehaines
Copy link
Contributor

  • Bump versions of Expo packages we rely on to match the ones required by Expo 40
  • Add another version check to expo-cli — assuming we'll release the RN CLI first, otherwise this will need to change slightly

@imjoehaines
Update Expo packages to match Expo SDK 40 versions
125d381
@imjoehaines
Use a compatible expo version pre SDK 40
ee30c30
@imjoehaines
Tweak expo contributing guide
2a78b2e 
- Removed a duplicate 'expo-constants'
- Split out netinfo into its own bullet point
- Removed changelogVersions as the other file is more relevant
- Add a note to update the docs
@github-actions
Copy link

github-actions bot commented Jan 4, 2021 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 40.70 kB 12.54 kB
After 40.70 kB 12.54 kB
± No change No change

Generated by 🚫 dangerJS against 6749bce

bengourley
bengourley approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@bengourley bengourley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset looks good, but let's hold until the promise rejection issue is resolved.

@imjoehaines imjoehaines merged commit 599fa45 into next Jan 6, 2021
@imjoehaines imjoehaines deleted the expo-40 branch January 6, 2021 15:38
@djskinner djskinner mentioned this pull request Jan 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengourley bengourley bengourley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @bengourley